Automatic code setup: Further improvements#1223
Open
t-reents wants to merge 1 commit intoaiidateam:mainfrom
Open
Automatic code setup: Further improvements#1223t-reents wants to merge 1 commit intoaiidateam:mainfrom
t-reents wants to merge 1 commit intoaiidateam:mainfrom
Conversation
* Add info that connection might take a while * Escape executable name when searching for it on remote computer
mbercx
requested changes
Dec 8, 2025
|
|
||
| try: | ||
| echo.echo_report( | ||
| 'Locating executables on the remote computer. Depending on the connection, this may take a while...' |
Member
There was a problem hiding this comment.
The computer isn't necessarily remote though? I suppose we only need to warn the user here in case the transport isn't core.local? That should not take a while. ^^
Nitpick/bike shedding: should we use echo_info instead?
| combined_prepend_text = f'{computer.get_prepend_text()}\n{prepend_text}' | ||
| return_value, stdout, stderr = transport.exec_command_wait( | ||
| command=f'. /dev/stdin > /dev/null && which {executable}', stdin=combined_prepend_text | ||
| command=f'. /dev/stdin > /dev/null && which {escape_for_bash(executable)}', |
Member
There was a problem hiding this comment.
If we already add validation on the executables in #1222, is this still necessary?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressing remaining aspects in #1156 (in addition to the changes in #1222)