Move query_params dependency logic into QueryParams model
#103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The implementation as in aiida-core.
edan-bainglass
force-pushed
the
simplify-query-params
branch
2 times, most recently
from
54dcf06 to
d451778
Compare
edan-bainglass
force-pushed
the
simplify-query-params
branch
from
d451778 to
1736759
Compare
Member
Author
|
Turns out to be more complex. Reverting (or rather just closing). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #102
This PR simply merges the
query_paramsdependency into theQueryParamsmodel and marks the model as aQuerypart in endpoints.