Improve performance #112
Open
Improve performance #112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The implementation as in aiida-core.
This was referenced Jan 17, 2026
edan-bainglass
force-pushed
the
improve-performance
branch
from
60e4ee7 to
a6d4b43
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #110
This PR greatly improves fetching performance (10x) for
get_manyendpoints. It does so by avoiding the iterative serialization of node results, instead projecting on the fields which manual serialization would yield (predicatable). Validation is retained by way of FastAPIsresponse_model.This PR implements a similar approach also for
get/add_oneendpoints, though in principle the performance boost here is negligible. It does so for consistency, though perhaps (to be discussed) we can retain the manual serialization for these endpoints. Note that foradd_oneendpoints, it is more convenient to retain it (already done in this PR).