Add daemon routers #89
Open
+68
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR migrate the daemon routers from aiida-gui to here. - get_daemon_worker - increase_daemon_worker - decrease_daemon_worker
Comment on lines
+25
to
+41
| class WorkerInfo(BaseModel): | ||
| """Details for a single daemon worker (per PID).""" | ||
|
|
||
| mem_info1: str = Field(..., description='Resident memory.') | ||
| mem_info2: str = Field(..., description='Virtual memory.') | ||
| cpu: float = Field(..., description='CPU usage percent.') | ||
| mem: float = Field(..., description='Memory usage percent.') | ||
| ctime: str = Field(..., description='CPU time as string.') | ||
| pid: int | ||
| username: str | ||
| nice: int | ||
| create_time: float = Field(..., description='Process creation time.') | ||
| age: float = Field(..., description='Process age in seconds.') | ||
| cmdline: str | ||
| children: t.List[t.Union[int, str]] = Field(default_factory=list, description='Child PIDs.') | ||
| started: float = Field(..., description='Worker start time.') | ||
| wid: int = Field(..., description='AiiDA worker id.') |
Member
There was a problem hiding this comment.
In the spirit of providing schemas for AiiDA-things, I would consider defining this model somewhere in aiida-core. Not sure where though. Also, if we drop the engine, we will also drop daemon endpoints from this package, so let's wait.
| return {} | ||
|
|
||
| response = client.get_worker_info() | ||
| print(response['info']) |
Member
There was a problem hiding this comment.
Was this print for debugging? I suggest removing it.
| response = client.get_worker_info() | ||
| print(response['info']) | ||
|
|
||
| return response['info'] |
Member
There was a problem hiding this comment.
If response['info'] returns a dict[str, WorkerInfo], what is the key? The worker id?
Member
edan-bainglass
left a comment
edan-bainglass
left a comment
There was a problem hiding this comment.
Hi @superstar54. Sorry for the delay on this. I left some comments. Also, can you address the failing tests? 🙏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrate the daemon routers from aiida-gui to here.