Conversation
|
|
||
| def ensure_coroutine(coro_or_fn): | ||
| if asyncio.iscoroutinefunction(coro_or_fn): | ||
| if inspect.iscoroutinefunction(coro_or_fn): |
There was a problem hiding this comment.
asyncio.iscoroutinefunction was deprecated in 3.14,
inspect.iscoroutinefunction is in Python since 3.5 so safe to switch to
https://docs.python.org/3/library/inspect.html#inspect.iscoroutinefunction
|
@unkcpz this one should be easy to review 🙏 👼 |
There was a problem hiding this comment.
looks all good, thanks!
@danielhollas what is your opinion on drop py3.9 support?
|
I don't want to drop support since we're still using it in AiiDAlab. And honestly for this package which is very stable I don't see any advantage of dropping support, it would not give us anything. |
|
see this aiidateam/aiida-core#6672 I didn't realize they drop the py3.9 support in the new release. The only thing I want is to take that one line fix I did 1 year ago. It can be a nice fix that people not suffer from |
2 participants
Only one trivial deprecation warning, otherwise things seems to just work.