De-abstract Savable by making it a protocol#298
Closed
unkcpz wants to merge 47 commits intoaiidateam:masterfrom
Closed
De-abstract Savable by making it a protocol#298unkcpz wants to merge 47 commits intoaiidateam:masterfrom
Savable by making it a protocol#298unkcpz wants to merge 47 commits intoaiidateam:masterfrom
Conversation
34d9b01 to
d524e63
Compare
e149bd2 to
a90dcff
Compare
…and asyncio.Future hand write wrap to kiwipy future (concurrent.futures.Future) kiwipy.Future -> concurrent.futures.Future
Move communication to rmq
a90dcff to
845a7d6
Compare
create_state refact Hashable initialized + parameters passed to Hashable Fix pre-commit errors
For the auto_persist attributes, the fn auto_save will take care of save the state
- stepper de-abstract - remove ContextMixin - Stepper all using recreate_from
- remove persist_config flag of savable
1315e38 to
0a3b65e
Compare
Since it is only used there
4fae0db to
76c887f
Compare
Member
Author
|
Not planed anymore. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The outcome of this refactoring is that the
Savablebecome a protocol which provide the contract for how things needed to be saved should implemented.Compare to the original implementation where
savecallssave_instance_statecalls each other recursively until all savable things is saved, the new implementation force thesavemethod independent and have symmetry behavior ofrecreate_from.unkcpz#5