Closed
Conversation
Calling `Waiting.resume()` when it had already been resumed would raise an exception. Here, the method is made idempotent by checking first whether the future has already been resolved. This fix ensures the behavior matches the behavior of the other state transitions: calling `play` on an already running process and calling `pause` on an already paused process isn't rising any error. (cherry picked from commit 20e5898)
(cherry picked from commit b3837fc)
This is a temporary workaround for `aio-pika` breaking for v4.5.0 See mosquito/aio-pika#649 (cherry picked from commit 3b9318c)
* Bump version for pytest and pytest tools * Use ruff with aligning to aiida-core ruff config * Update mypy to 1.13.0 * Remove all pylint ignore annotations * Bump ruff to 0.8.0 for sort the imports * Update python version to 3.12 for pre-commit CI * Double quotes for eval inside single quotes f-strings * Exclude tests/.* for ruff linting * Do not fail-fast so tests for different python version independent (cherry picked from commit 55e05e9)
Since kiwipy pinning the upbound version of aio-pika to 9.4.0 to not include the bug of typing-extentions import error of mosquito/aio-pika#649. (cherry picked from commit e06d522)
(cherry picked from commit bb32edb)
…on (#291) The messages to passing over rabbitmq for process control is build dynamically and able to carry more information. In the old implementation, the messages ace global dictionary variables and when the message need to change by copy which is error-prone. This commit introduce the `MessageBuilder` with class methods for creating kill/pause/status/play messages. For "kill" message, I also add support for passing the `force_kill` option. (cherry picked from commit f760b4a)
Amend for message build, now also construct message for pause operations. * Rename `MESSAGE_KEY` to `MESSAGE_TEXT_KEY` (cherry picked from commit a4b8962)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.