Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactor CI workflow to detect tags from git repository and optimize release job execution.
Motivation
The release job previously relied on
github.refto detect tags, which doesn't work when tags are created by other workflows.Changes
workflow_runtrigger to automatically run maturin workflow after weekly PSL updateifcondition from release job that depended ongithub.refcheck-tagjob to detect pyfaup-rs-v* tags usinggit tag --points-at HEADcheck-tagdepend on all build jobs (linux, musllinux, windows, macos, sdist)check-tagjob indicating if matching tag existsreleasejob depend oncheck-taginstead of build jobsiftoreleasejob to only run when tag is presentBreaking Changes
None