Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add IPv6 zone ID support and refactor Host enum to separate IPv4/IPv6 variants.
Motivation
IPv6 addresses can include zone IDs (interface identifiers) in the format
[address%zone]. The parser needed to support this syntax, and the Host enum was refactored to better distinguish between IPv4 and IPv6 addresses.Changes
Host::Ipenum variant intoHost::IpV4andHost::IpV6Host::IpV6variant (storesIpv6AddrandOption<Cow<'url, str>>)%followed by any characters except])is_hostname(),is_ipv4(), andis_ipv6()methods to Host::1)Breaking Changes
Hostenum variantIphas been split intoIpV4andIpV6Hostenum:Ipvariant renamed toIpv4andIpv6Host::Ipmust be updated to match specific variantsTesting
Notes
The zone ID is parsed and stored in the Rust API but is not yet exposed through the Python bindings. The Python bindings currently only expose the IPv6 address without the zone ID. This is a known limitation that may need to be addressed in a future update.