Merged
Conversation
Support parsing URLs with trailing dots in hostnames (e.g., shops.myshopify.com./) by modifying grammar rules and adding trailing dot trimming. This addresses issue #18.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Support parsing URLs and domains containing a trailing dot in the hostname (e.g.,
http://shops.myshopify.com./). This addresses issue #18.Motivation
URLs with trailing dots in hostnames are valid according to RFC standards but were previously rejected by the parser. This change enables proper parsing of such URLs while maintaining backward compatibility.
Changes
trim_end_matches(".")to strip trailing dots from hostnames during parsingBreaking Changes
None
Testing
test_url_trailing_dot()with multiple test casesNotes
The trailing dot is stripped during parsing but the original URL string remains unchanged in the
origfield.