Skip to content

Fix error when file of report doesn't exist #407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
korhenon merged 3 commits into from
Mar 3, 2026
Merged

Fix error when file of report doesn't exist #407

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
89adf22
fix: OSA crash if report isn't exist
korhenon Feb 27, 2026
33cfc99
fix: black format
korhenon Feb 27, 2026
69c48fe
fix: errors in some new places
korhenon Mar 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions osa_tool/run.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ def main():
analytics = ReportGenerator(config_manager, git_agent.metadata)
try:
analytics.build_pdf()
if create_fork:
if create_fork and os.path.exists(analytics.output_path):
git_agent.upload_report(analytics.filename, analytics.output_path)
plan.mark_done("report")
except ValueError:
Expand All @@ -106,7 +106,7 @@ def main():
if content:
va_re_gen = ValidationReportGenerator(config_manager, git_agent.metadata)
va_re_gen.build_pdf("Document", content)
if create_fork:
if create_fork and os.path.exists(va_re_gen.output_path):
git_agent.upload_report(va_re_gen.filename, va_re_gen.output_path)
plan.mark_done("validate_doc")
else:
Expand All @@ -120,7 +120,7 @@ def main():
if content:
va_re_gen = ValidationReportGenerator(config_manager, git_agent.metadata)
va_re_gen.build_pdf("Paper", content)
if create_fork:
if create_fork and os.path.exists(va_re_gen.output_path):
git_agent.upload_report(va_re_gen.filename, va_re_gen.output_path)
plan.mark_done("validate_paper")
else:
Expand Down Expand Up @@ -221,7 +221,15 @@ def main():
plan.mark_done("delete_dir")

if plan.get("report"):
WhatHasBeenDoneReportGenerator(config_manager, plan.list_for_report, git_agent.metadata).build_pdf()
try:
report_generator = WhatHasBeenDoneReportGenerator(
config_manager, plan.list_for_report, git_agent.metadata
)
report_generator.build_pdf()
if create_fork and os.path.exists(report_generator.output_path):
git_agent.upload_report(report_generator.filename, report_generator.output_path)
except Exception as e:
logger.error("Error while generating after report: %s", repr(e), exc_info=True)

elapsed_time = time.time() - start_time
rich_section(f"All operations completed successfully in total time: {format_time(elapsed_time)}")
Expand Down