Skip to content

Comments

Added placeholder image for receipes#267

Open
mr-woodapple wants to merge 2 commits intoaimok04:mainfrom
mr-woodapple:feature/placeholderImage
Open

Added placeholder image for receipes#267
mr-woodapple wants to merge 2 commits intoaimok04:mainfrom
mr-woodapple:feature/placeholderImage

Conversation

@mr-woodapple
Copy link

@mr-woodapple mr-woodapple commented Aug 30, 2025

Added a placeholder image that is shown if a receipe has no image attached.
Also added the source files for these icons at /assets, I have created them myself.

Haven't been able to test it on iPhone, it works on the Android emulator just fine.

Screenshot_20250901_204603 Screenshot_20250901_204522

@aimok04
Copy link
Owner

aimok04 commented Sep 2, 2025

Hi,

Thanks for the PR, I really like the placeholder icon! :)

But I have some concerns about contrast.
For example, when opening the recipe view:

Screenshot_20250902_105526

So my idea would be to

  1. Add the MeltingDome.ai icon as a vector drawable
  2. Create a shared cover image Composable for recipes that uses the Icon() composable to display the MeltingDome icon when the loadThumbnail() function returns null.
    • This way we also could use the tint parameter of Icon() to change the color when using dark/light theme and maybe also use a color from the material color scheme.

If you'd like you can do this, but if you are unsure about how to implement it I would also be willing to implement it! :)

I am not very experienced with Adobe Products, .ai is already a vector image, right? 😅

@mr-woodapple
Copy link
Author

Thanks for having a look at it!

Ahh perfect, I was hoping to do something like this, but couldn't figure out how to display an .svg (the file wouldn't load using coil3. I do fancy giving it a go myself, might come back and ask for help if I'm stuck somewhere (because I'm have barely any experience with Flutter).

Re the .ai file: Kinda, but you would need to export it as an .svg file. I can add one to the /assets folder. :)

@aimok04
Copy link
Owner

aimok04 commented Sep 2, 2025

(because I'm have barely any experience with Flutter).

Flutter is a different thing! :)

Kitshn is using Compose Multiplatform. Compose is a framework made by Google for Android and Compose Multiplatform is a project by Jetbrains which brings Compose to other platforms.

Re the .ai file: Kinda, but you would need to export it as an .svg file. I can add one to the /assets folder. :)

Yes, that would be nice!

You can convert svgs to Android/.xml icons in Android Studio, which is (I think) the only way to load vector graphics natively.

@mr-woodapple
Copy link
Author

Flutter is a different thing! :)

I know, but I thought Compose Multiplatform is written in Kotlin? Or at least the language used to define the app is Kotlin...

You can convert svgs to Android/.xml icons in Android Studio, which is (I think) the only way to load vector graphics natively.

Okay great, I'll have a look into it! :)

@aimok04
Copy link
Owner

aimok04 commented Sep 2, 2025

I know, but I thought Compose Multiplatform is written in Kotlin? Or at least the language used to define the app is Kotlin...

Now I am confused 😆
Yeah it is, but Flutter apps are written in dart or did I mix something up here 😄

@mr-woodapple
Copy link
Author

Meant Kotlin, wrote Flutter. Forget about it. 😂

@mr-woodapple
Copy link
Author

Hi, very sorry for the delay, but I currently don't have the time to implement the feature myself. If you still wanna continue on it, I've added the .svg files to the repo, let me know if you need any other files from me, always happy to help where I can!

@aimok04
Copy link
Owner

aimok04 commented Oct 13, 2025

Hi, very sorry for the delay, but I currently don't have the time to implement the feature myself. If you still wanna continue on it, I've added the .svg files to the repo, let me know if you need any other files from me, always happy to help where I can!

Oh absolutely no problem! :)

I'll work on it.

@aimok04
Copy link
Owner

aimok04 commented Oct 13, 2025

Thanks for providing the .svg! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants