Relax botocore dependency specification#1474
Conversation
|
Important Installation incomplete: to start using Gemini Code Assist, please ask the organization owner(s) to visit the Gemini Code Assist Admin Console and sign the Terms of Services. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1474 +/- ##
=======================================
Coverage 91.60% 91.60%
=======================================
Files 76 76
Lines 8078 8078
=======================================
Hits 7400 7400
Misses 678 678
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
webknjaz
left a comment
There was a problem hiding this comment.
In pip-tools, we're talking about having an extra with an upper bound for the dep we're actually testing. In general, upper boundaries in mandatory metadata is considered harmful (with my PyPA hat on) and such bumps create a lot of noise too causing too much burden (with my serial maintainer hat). For this reason, I tend to configure dep bumping automations (dependabot, pre-commit.ci etc) to be as unfrequent as possible, short of security fixes, of course.
Having to approve this many seemingly pointless bumps every day just steals time from more urgent/useful maintenance needs. I'm approving this but I'll probably change the branch protection to allow self-approvals to try to reduce this burden. Though the correct fix is not having the upper bounds in this place of the metadata.
Makes a lot of sense to me.
aiobotocore by design relies on patching of private |
|
Opened #1475 to pick up your suggestion and continue discussion. |
Description of Change
This PR intends to improve general compatibility of
aiobotocorewithin the Python ecosystem by relaxing the dependency specification ofbotocore.Assumptions
Upstream contains no changes that require adjustments to the aiobotocore codebase.
Checklist for All Submissions
Checklist when updating botocore and/or aiohttp versions