Open
Conversation
Member
|
Any typing improvements will need to wait until other tasks on the v1 milestone are complete. At the very least, we need mypy running, but that's currently blocked by 3 tasks preceding it: https://github.com/aio-libs/aiocache/milestone/8 |
|
@fabiob @Dreamsorcerer any update on this PR? It will help for any project that uses type checking |
Member
|
See the previous comment: #838 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do these changes do?
They add strong typing to
aiocachedecorator syntax.Are there changes in behavior for the user?
Somewhat, as their IDEs will start to hint at the expected usage of the decorators.
Related issue number
It is related to #512 and #791
Checklist