Different Eventloops on windows can now be explored #178
+22
−152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
whoops I did not take ProactorEventLoop attribute into account. When I get back from other activities I will fix this immediately. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #178 +/- ##
==========================================
- Coverage 97.25% 97.01% -0.24%
==========================================
Files 3 3
Lines 547 503 -44
Branches 34 31 -3
==========================================
- Hits 532 488 -44
Misses 8 8
Partials 7 7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thank goodness I got all of that done. That took longer than it needed to to solve. |
|
Thanks. Once we sort out #175 we can move this forward |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
These Changes unlock the ability to use different event-loops with Windows in the future. This will allow users to explore other ideas and workarounds to maybe even Subclass the
ProactorEventLoopto get no-event threads instances to work. Winloop no longer needs to be imported to aiodns thus saving a bit of time with checking and configuring. I moved it to a function mainly to be simulated but I can always move these parts back to the make_channel function if needed.Are there changes in behavior for the user?
Users will no longer be locked to using winloop or the SelectorEventLoop if a windows operating system is being used. Importing winloop to aiodns inside the dns resolver no longer needs to be done. I changed the wording of the error message. Now it says it requires any eventloop but the ProactorEventLoop aiodns cannot use ProactorEventLoop on Windows if event-threads cant be utilized implying that winloop or the SelectorEventLoop or Any Custom EventLoops instead.
Related issue number
Checklist