Skip to content

Fix test that creates orphan process #711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Dreamsorcerer merged 1 commit into from
Jan 9, 2025
Merged

Fix test that creates orphan process #711

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions tests/test_runserver_main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ async def hello(request):


@forked
def test_start_runserver_with_multi_app_modules(tmpworkdir, capfd):
async def test_start_runserver_with_multi_app_modules(tmpworkdir, capfd):
mktree(tmpworkdir, {
"app.py": f"""\
from aiohttp import web
Expand Down Expand Up @@ -149,10 +149,13 @@ async def create_app():
app_task = AppTask(config)

app_task._start_dev_server()
app_task._process.join(2)
try:
app_task._process.join(2)

captured = capfd.readouterr()
assert captured.out == ""
captured = capfd.readouterr()
assert captured.out == ""
finally:
await app_task._stop_dev_server()


@forked
Expand Down
Loading