-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
[PR #11367/cccbf4cd backport][3.13] Disable the blockbuster fixture when the module is not importable #11402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Dreamsorcerer
merged 1 commit into
3.13
from
patchback/backports/3.13/cccbf4cd3390729afe6ebe4c1078c2c979016503/pr-11367
Aug 10, 2025
Merged
[PR #11367/cccbf4cd backport][3.13] Disable the blockbuster fixture when the module is not importable #11402
Dreamsorcerer
merged 1 commit into
3.13
from
patchback/backports/3.13/cccbf4cd3390729afe6ebe4c1078c2c979016503/pr-11367
Aug 10, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
❌ 7 Tests Failed:
View the top 2 failed test(s) by shortest run time
View the full list of 1 ❄️ flaky tests
To view more test analytics, go to the Test Analytics Dashboard |
The CI hasn't even started yet... |
CodSpeed Performance ReportMerging #11402 will not alter performanceComparing Summary
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #11367 as merged into master (cccbf4c).
What do these changes do?
This makes blockbuster an actually optional test dependency; see cbornet/blockbuster#46 (comment).
Try to import the
blockbuster
module intests/conftest.py
; if it succeeds, disableautouse
for the blockbuster fixture, and if it does end up getting used on a test, skip it in the same manner currently used for tests decorated with@pytest.mark.skip_blockbuster
.The result is that the tests can still run when the
blockbuster
module is not available in the environment; before, it was unconditionally imported no matter what, so it wasn’t really an optional test dependency in practice.This is useful in Fedora, where we package
python-aiohttp
but we would rather avoid packagingpython-blockbuster
and its dependencypython-forbiddenfruit
if possible – see cbornet/blockbuster#46 for context. It is likely to be useful for other distribution packagers as well.This PR replaces #11363, which was based on incomplete understanding.
Are there changes in behavior for the user?
No, only for people running the tests without installing all of the declared test dependencies.
Is it a substantial burden for the maintainers to support this?
It should be no burden at all.
Related issue number
N/A
Checklist
CONTRIBUTORS.txt
aiohttp/CONTRIBUTORS.txt
Line 62 in f42b73a
CHANGES/
folder