Skip to content

Skip benchmarks in ci when running in fork repositories #11737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
+41 −7
Open

Skip benchmarks in ci when running in fork repositories #11737

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
812fd75
skip codecov upload and benchmarks in forks
Cycloctane Oct 19, 2025
b705ecd
add changelog
Cycloctane Oct 29, 2025
b2075ba
remove condition in test workflow
Cycloctane Oct 29, 2025
bd23653
use repository id instead of owner name
Cycloctane Oct 29, 2025
c0ed62c
update changelog
Cycloctane Oct 29, 2025
ca17839
update changelog
Cycloctane Oct 29, 2025
eade60a
Update CHANGES/11737.contrib.rst
Cycloctane Oct 30, 2025
0b9f602
update ci-cd
Cycloctane Oct 30, 2025
ae92397
fix syntax
Cycloctane Oct 30, 2025
5c1d66d
Annotate transitive job deps with context comments
webknjaz Nov 5, 2025
3eafe55
Add an explicit ternary for the `release-requested` value
webknjaz Nov 5, 2025
cdbcb60
Remove codspeed token from CI/CD benchmarks step
Cycloctane Nov 16, 2025
6dc6b3e
Always skip the dummy step in pre-setup
webknjaz Nov 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 38 additions & 7 deletions .github/workflows/ci-cd.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,33 @@ env:
FORCE_COLOR: 1 # Request colored output from CLI tools supporting it
MYPY_FORCE_COLOR: 1
PY_COLORS: 1
UPSTREAM_REPOSITORY_ID: >-
13258039

permissions: {}

jobs:

pre-setup:
name: Pre-Setup global build settings
runs-on: ubuntu-latest
outputs:
upstream-repository-id: ${{ env.UPSTREAM_REPOSITORY_ID }}
release-requested: >-
${{
(
github.event_name == 'push'
&& github.ref_type == 'tag'
)
&& true
|| false
}}
steps:
- name: Dummy
if: false
run: |
echo "Pre-setup step"

lint:
permissions:
contents: read # to fetch code (actions/checkout)
Expand Down Expand Up @@ -259,8 +282,11 @@ jobs:

benchmark:
name: Benchmark
needs: gen_llhttp

needs:
- gen_llhttp
- pre-setup # transitive, for accessing settings
if: >-
needs.pre-setup.outputs.upstream-repository-id == github.repository_id
runs-on: ubuntu-latest
timeout-minutes: 12
steps:
Expand Down Expand Up @@ -295,7 +321,6 @@ jobs:
uses: CodSpeedHQ/action@v4
with:
mode: instrumentation
token: ${{ secrets.CODSPEED_TOKEN }}
Copy link
Member

@webknjaz webknjaz Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aparrently, they've implemented OIDC two days ago. Perhaps, we could configure it as a part of replacing this token: https://codspeed.io/docs/integrations/ci/github-actions/configuration#oidc-recommended

run: python -Im pytest --no-cov --numprocesses=0 -vvvvv --codspeed


Expand All @@ -317,9 +342,10 @@ jobs:
pre-deploy:
name: Pre-Deploy
runs-on: ubuntu-latest
needs: check
# Run only on pushing a tag
if: github.event_name == 'push' && contains(github.ref, 'refs/tags/')
needs:
- check
- pre-setup # transitive, for accessing settings
if: fromJSON(needs.pre-setup.outputs.release-requested)
steps:
- name: Dummy
run: |
Expand Down Expand Up @@ -465,8 +491,13 @@ jobs:

deploy:
name: Deploy
needs: [build-tarball, build-wheels]
needs:
- build-tarball
- build-wheels
- pre-setup # transitive, for accessing settings
runs-on: ubuntu-latest
if: >-
needs.pre-setup.outputs.upstream-repository-id == github.repository_id
Comment on lines +494 to +500
Copy link
Member

@webknjaz webknjaz Nov 21, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you move this to a separate PR?

Copy link
Member

@webknjaz webknjaz Nov 21, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, never mind. It's kinda related but the PR title+description+change note should reflect this.


permissions:
contents: write # IMPORTANT: mandatory for making GitHub Releases
Expand Down
3 changes: 3 additions & 0 deletions CHANGES/11737.contrib.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
The benchmark CI job now runs only in the upstream repository -- by :user:`Cycloctane`.

It used to always fail in forks, which this change fixed.
Loading