Skip to content

459.bugfix #459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

459.bugfix #459

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
11c3562
Closing connections properly when in a pool
summatix Dec 22, 2019
f11b0a7
Merge branch 'master' of github.com:aio-libs/aiomysql
summatix Jun 9, 2020
1dad293
Merge branch 'master' into master
Nothing4You Jan 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions aiomysql/connection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,6 +340,15 @@ def close(self):
self._writer = None
self._reader = None

async def close_async(self):
"""Close socket connection"""
if self._writer:
self._writer.close()
await self._writer.wait_closed()

self._writer = None
self._reader = None

async def ensure_closed(self):
"""Send quit command and then close socket connection"""
if self._writer is None:
Expand Down
2 changes: 1 addition & 1 deletion aiomysql/pool.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ async def wait_closed(self):

while self._free:
conn = self._free.popleft()
conn.close()
await conn.close_async()

async with self._cond:
while self.size > self.freesize:
Expand Down