ensure test_scroll_errors and test_sscursor_scroll_errors initialize their tables #694
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…their tables this resulted in test failures in some cases.
Codecov Report
@@ Coverage Diff @@
## master #694 +/- ##
=======================================
Coverage 85.70% 85.70%
=======================================
Files 12 12
Lines 2085 2085
Branches 336 336
=======================================
Hits 1787 1787
Misses 228 228
Partials 70 70
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
When changing the order of some tests, e.g. not running asyncio and uvloop tests next to each other, these missing prepares can currently lead to test failures.
This failed e.g. in #693.
I have not yet checked why this wouldn't always fail, as it seems that sometimes these tables are available, but this fixes the tests to only rely on data expected to be present.