Skip to content

Conversation

Vizonex
Copy link

@Vizonex Vizonex commented Aug 5, 2025

What do these changes do?

These Changes add better type hints through the entire code and not just places that users have access to but all of it. I also added __slots__ to try and increase the performance of these locks, As for #468 I did add a todo that this should be investigated otherwise dropped.

Edit: I also ran ruff to format everything and I even ran isort as the cherry on top.

Are there changes in behavior for the user?

More functions have been documented and with __slots__ added should improve the speed of the locks in general. With tests now properly type hinted at it allow for at least some improved readability.

Related issue number

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes

…nt more functions that users have direct access to
@Dreamsorcerer
Copy link
Member

"add typehints and refactor lock objects and add more documentation"
That's like 3 PRs. Would be nice to keep changes in smaller steps.

@Vizonex
Copy link
Author

Vizonex commented Aug 5, 2025

"add typehints and refactor lock objects and add more documentation" That's like 3 PRs. Would be nice to keep changes in smaller steps.

I guess I'll close and try doing this in smaller steps then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants