Skip to content

Fix _FakeServer to immediately close client connections #524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix _FakeServer to immediately close client connections #524

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
06740c4
Fix _FakeServer to immediately close client connections
cuu508 Oct 28, 2024
96f7a17
Remove _FakeServer._cb_client_connected, don't think it's used
cuu508 Mar 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions aiosmtpd/controller.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,14 +99,11 @@ def __init__(self, loop: asyncio.AbstractEventLoop):
# Imitate what SMTP does
super().__init__(
asyncio.StreamReader(loop=loop),
client_connected_cb=self._cb_client_connected,
loop=loop,
)

def _cb_client_connected(
self, reader: asyncio.StreamReader, writer: asyncio.StreamWriter
) -> None:
pass
def connection_made(self, transport):
transport.close()


@public
Expand Down
1 change: 0 additions & 1 deletion aiosmtpd/tests/test_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -535,7 +535,6 @@ def test_inet_contstop(self, temp_event_loop, runner):
assert temp_event_loop.is_closed() is False


@pytest.mark.skipif(sys.version_info >= (3, 12), reason="Hangs on 3.12")
@pytest.mark.filterwarnings("ignore::pytest.PytestUnraisableExceptionWarning")
class TestFactory:
def test_normal_situation(self):
Expand Down
Loading