Skip to content

Conversation

@fanthos
Copy link

@fanthos fanthos commented Nov 20, 2024

For max compatibity, response from AUTH LOGIN shouhd be Username instead of User Name.

What do these changes do?

Most SMTP server response Username when AUTH LOGIN, not User Name.
Improve compatiblity with some smtp client.

Are there changes in behavior for the user?

Server return base64 encoded Username instead of User Name.

Related issue number

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • tox testenvs have been executed in the following environments:
    • Linux (Ubuntu 18.04, Ubuntu 20.04, Arch): {py36,py37,py38,py39}-{nocov,cov,diffcov}, qa, docs
    • Windows (7, 10): {py36,py37,py38,py39}-{nocov,cov,diffcov}
    • WSL 1.0 (Ubuntu 18.04): {py36,py37,py38,py39}-{nocov,cov,diffcov}, pypy3-{nocov,cov}, qa, docs
    • FreeBSD (12.2, 12.1, 11.4): {py36,pypy3}-{nocov,cov,diffcov}, qa
    • Cygwin: py36-{nocov,cov,diffcov}, qa, docs
  • Documentation reflects the changes
  • Add a news fragment into the NEWS.rst file
    • Add under the "aiosmtpd-next" section, creating one if necessary
      • You may create subsections to group the changes, if you like
    • Use full sentences with correct case and punctuation
    • Refer to relevant Issue if applicable

For max compatibity, response from AUTH LOGIN shouhd be `Username` instead of `User Name`.
@fanthos fanthos changed the title Update smtp.py set AUTH challenge from "User Name" to "Username" [WIP]Update smtp.py set AUTH challenge from "User Name" to "Username" Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant