-
-
Notifications
You must be signed in to change notification settings - Fork 110
Drop mypy coverage #1174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Drop mypy coverage #1174
Conversation
CodSpeed Performance ReportMerging #1174 will not alter performanceComparing Summary
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1174 +/- ##
===========================================
+ Coverage 98.62% 100.00% +1.37%
===========================================
Files 27 25 -2
Lines 3566 3112 -454
Branches 561 197 -364
===========================================
- Hits 3517 3112 -405
+ Misses 17 0 -17
+ Partials 32 0 -32
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still think that recording type preciseness is useful. That hasn't changed 🤷♂️
It's useful for tracking the type preciseness dynamics over time. I've responded in the issue on the options to hide the checks from the widget. But we shouldn't stop tracking the data. And to reiterate — Codecov won't show you patch coverage reliably in many of its views. You have to look at the local report if your goal isn't to be misled. |
Closes #1122