Skip to content

Conversation

asvetlov
Copy link
Member

@asvetlov asvetlov commented Jun 11, 2025

Closes #1122

@asvetlov asvetlov requested a review from webknjaz as a code owner June 11, 2025 12:25
@asvetlov asvetlov added the bot:chronographer:skip This PR does not need to include a change note label Jun 11, 2025
Copy link

codspeed-hq bot commented Jun 11, 2025

CodSpeed Performance Report

Merging #1174 will not alter performance

Comparing drop-mypy-coverage (331a66c) with master (bdbbc48)

Summary

✅ 244 untouched benchmarks

Copy link

codecov bot commented Jun 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (bdbbc48) to head (924d52d).

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #1174      +/-   ##
===========================================
+ Coverage   98.62%   100.00%   +1.37%     
===========================================
  Files          27        25       -2     
  Lines        3566      3112     -454     
  Branches      561       197     -364     
===========================================
- Hits         3517      3112     -405     
+ Misses         17         0      -17     
+ Partials       32         0      -32     
Flag Coverage Δ
CI-GHA 100.00% <ø> (+1.37%) ⬆️
MyPy ?
pytest 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@webknjaz webknjaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still think that recording type preciseness is useful. That hasn't changed 🤷‍♂️

@asvetlov
Copy link
Member Author

@webknjaz is it useful for what?
Please elaborate.
Also, please answer the questions asked in #1122

@webknjaz
Copy link
Member

It's useful for tracking the type preciseness dynamics over time. I've responded in the issue on the options to hide the checks from the widget. But we shouldn't stop tracking the data.

And to reiterate — Codecov won't show you patch coverage reliably in many of its views. You have to look at the local report if your goal isn't to be misled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop typing coverage
2 participants