Fix missing space in ValueError message#1296
Fix missing space in ValueError message#1296veeceey wants to merge 3 commits intoaio-libs:masterfrom
Conversation
|
Alright.. Please add a regression test. |
Also fix changelog entry to avoid unresolvable :func: reference to private _parse_args function that was causing Sphinx build failure.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1296 +/- ##
=======================================
Coverage 99.85% 99.85%
=======================================
Files 26 26
Lines 3513 3513
Branches 253 253
=======================================
Hits 3508 3508
Misses 3 3
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
webknjaz
left a comment
There was a problem hiding this comment.
No need to duplicate an existing test. Just update it.
Vizonex
left a comment
There was a problem hiding this comment.
Looks good no complaints from me.
|
Done -- updated the existing |
|
Hi @webknjaz, I updated the existing test as you suggested instead of duplicating it — the test_cannot_create_from_unaccepted test now checks the full message including the spacing fix. Happy to adjust if you'd prefer a different approach. |
Summary
Fix missing space in the
ValueErrormessage raised by_parse_args()-- the implicit string concatenation between the two f-strings was missing a trailing space, producing"element #0has"instead of"element #0 has".Test plan