Skip to content

Fix missing space in ValueError message#1296

Open
veeceey wants to merge 3 commits intoaio-libs:masterfrom
veeceey:fix/error-message-missing-space
Open

Fix missing space in ValueError message#1296
veeceey wants to merge 3 commits intoaio-libs:masterfrom
veeceey:fix/error-message-missing-space

Conversation

@veeceey
Copy link
Contributor

@veeceey veeceey commented Feb 10, 2026

Summary

Fix missing space in the ValueError message raised by _parse_args() -- the implicit string concatenation between the two f-strings was missing a trailing space, producing "element #0has" instead of "element #0 has".

Test plan

  • Verified the corrected message output manually

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Feb 10, 2026
@codspeed-hq
Copy link

codspeed-hq bot commented Feb 10, 2026

Merging this PR will not alter performance

✅ 245 untouched benchmarks


Comparing veeceey:fix/error-message-missing-space (707c8ca) with master (dbebab0)

Open in CodSpeed

@webknjaz
Copy link
Member

Alright.. Please add a regression test.

Also fix changelog entry to avoid unresolvable :func: reference
to private _parse_args function that was causing Sphinx build failure.
@codecov
Copy link

codecov bot commented Feb 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.85%. Comparing base (8416839) to head (707c8ca).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1296   +/-   ##
=======================================
  Coverage   99.85%   99.85%           
=======================================
  Files          26       26           
  Lines        3513     3513           
  Branches      253      253           
=======================================
  Hits         3508     3508           
  Misses          3        3           
  Partials        2        2           
Flag Coverage Δ
CI-GHA 99.85% <100.00%> (ø)
pytest 99.85% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@webknjaz webknjaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to duplicate an existing test. Just update it.

@webknjaz webknjaz moved this to 🤦‍♂️ LLM/“AI” slop 🤖 in 📅 Procrastinating in public 😵‍💫 Feb 11, 2026
@github-project-automation github-project-automation bot moved this from 🤦‍♂️ LLM/“AI” slop 🤖 to 🚧 In progress 🚧 in 📅 Procrastinating in public 😵‍💫 Feb 11, 2026
@webknjaz webknjaz moved this from 🚧 In progress 🚧 to 🤦‍♂️ LLM/“AI” slop 🤖 in 📅 Procrastinating in public 😵‍💫 Feb 11, 2026
Copy link
Member

@Vizonex Vizonex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good no complaints from me.

@veeceey
Copy link
Contributor Author

veeceey commented Feb 14, 2026

Done -- updated the existing test_cannot_create_from_unaccepted to check the full message spacing instead of adding a separate test.

@veeceey
Copy link
Contributor Author

veeceey commented Feb 16, 2026

Hi @webknjaz, I updated the existing test as you suggested instead of duplicating it — the test_cannot_create_from_unaccepted test now checks the full message including the spacing fix. Happy to adjust if you'd prefer a different approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot:chronographer:provided There is a change note present in this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants