Open
Conversation
psf-chronographer
bot
added
the
bot:chronographer:provided
Jamim
force-pushed
the
feature/refactor-pickle-tests
branch
from
ea0e93e to
3eb82a4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #938 +/- ##
==========================================
+ Coverage 95.09% 95.63% +0.53%
==========================================
Files 21 20 -1
Lines 2407 2404 -3
Branches 275 271 -4
==========================================
+ Hits 2289 2299 +10
+ Misses 46 33 -13
Partials 72 72
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Jamim
force-pushed
the
feature/refactor-pickle-tests
branch
4 times, most recently
from
e763ee5 to
4bb5852
Compare
Jamim
force-pushed
the
feature/refactor-pickle-tests
branch
from
4bb5852 to
f4b7524
Compare
The main goal of these changes is to make test_pickle.py more readable and eliminate get_pickles.py. These changes: - add dict_data, pickled_data, and pickle_file_path fixtures - rename test_pickle to test_unpickle - add test_pickle_format_stability - replace test_load_from_file with test_pickle_backward_compatibility - replace get_pickles.py with test_write_pickle_file
Jamim
force-pushed
the
feature/refactor-pickle-tests
branch
from
f4b7524 to
b2b00a3
Compare
Contributor
Author
|
Hello @webknjaz, Would you mind reviewing this PR once you have a spare time? Thanks in advance! |
Member
|
I wanted to reflect on what I prefer with this. #924 and this one made me realize that I'm not sure yet. So I'd keep it open for the time being. |
Member
|
I've posted plugins to research @ #922 (comment). I'd like to go that route. If you're up for it, feel free to check them out and rework the approach using one of them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello @webknjaz,
What do these changes do?
The main goal of these changes is to make
test_pickle.pymore readable and eliminateget_pickles.py.These changes:
dict_data,pickled_data, andpickle_file_pathfixturestest_pickletotest_unpickletest_pickle_format_stabilitytest_load_from_filewithtest_pickle_backward_compatibilityget_pickles.pywithtest_write_pickle_fileAre there changes in behavior for the user?
No.
Related issue number
tests/gen_pickles.pywith a pytest plugin #922This PR is alternative to:
Checklist
Best regards!