Merged
Conversation
Collaborator
|
Contributor
Author
|
I agree with all those suggestions, but none of that is related to the changes of this PR. Can I assume that the proposed changes here are good? |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
To create the new realm files, I loaded the old ones, then did an export. I assume this preserves all the relevant information, the new exports only contains the aiod realm data and not any admin realm data (though as far as I could tell this was already the case in the old file).
How to Test
Go to the admin console (http://localhost/aiod-auth) login with default credentials, and see that the reviewer role and user exist. On the REST API doc page, log in as reviewer and call the
authorization_testendpoint to see the role is visible from the REST API.This change is not covered by unit tests because keycloak configuration isn't tested.
Checklist
Related Issues
Preparation for #435 which uses the reviewer role.