Skip to content

Remove the schemaorg dependencies since it is not used#574

Merged
PGijsbers merged 2 commits intodevelopfrom
remove-schemaorg
Jul 22, 2025
Merged

Remove the schemaorg dependencies since it is not used#574
PGijsbers merged 2 commits intodevelopfrom
remove-schemaorg

Conversation

@PGijsbers
Copy link
Contributor

@PGijsbers PGijsbers commented Jul 22, 2025

Change

Remove the pydantic_schemaorg dependency since it is not used.

How to Test

CI.

Checklist

  • Tests have been added or updated to reflect the changes, or their absence is explicitly explained: Change has no effect on the application.
  • Documentation has been added or updated to reflect the changes, or their absence is explicitly explained: Change has no effect on the application
  • A self-review has been conducted checking:
    • No unintended changes have been committed.
    • The changes in isolation seem reasonable.
    • Anything that may be odd or unintuitive is provided with a GitHub comment explaining it (but consider if this should not be a code comment or in the documentation instead).
  • All CI checks pass before pinging a reviewer, or provide an explanation if they do not.

Related Issues

@PGijsbers PGijsbers requested review from Taniya-Das and removed request for Taniya-Das July 22, 2025 09:02
"mysqlclient==2.2.4",
"oic==1.6.0",
"python-keycloak==3.7.0",
"pydantic<2",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was previously implicit because pydantic_schemaorg pins it to some specific 1.x version.

Copy link
Collaborator

@Taniya-Das Taniya-Das left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PGijsbers PGijsbers merged commit 7fb4789 into develop Jul 22, 2025
4 checks passed
@PGijsbers PGijsbers deleted the remove-schemaorg branch July 22, 2025 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants