Conversation
PGijsbers
commented
Sep 2, 2025
| - id: pytest-check | ||
| name: pytest-check | ||
| entry: pytest src/tests --versions '' | ||
| entry: pytest src/tests --versions 'latest' |
Contributor
Author
There was a problem hiding this comment.
I also made a few small internal changes to allow us to specify versions in the same was as Version when restricting tests, so we can use fewer magical strings and better parse user input.
Contributor
Author
There was a problem hiding this comment.
It also fixes a bug where the parametrization wouldn't work for any version other than latest (see below).
PGijsbers
commented
Sep 2, 2025
| client = TestClient( | ||
| app, | ||
| base_url=f"http://localhost/{request.param.prefix}", # param is Version | ||
| base_url=f"http://localhost{request.param.prefix}/", # param is Version |
Contributor
Author
There was a problem hiding this comment.
Since Version.prefix was e.g., /v3 this lead to localhost//v3 instead of localhost/v3. This wasn't caught by pre-commit since it only runs against latest. I am not sure why CI/CD in the PR (#596) didn't catch it, but in the merge commit of develop it was broken.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change(s)
Change Type: Added
Change Category: Interface
Changelog Entry:
Add pagination to
/bookmarksPagination limits and offsets can now be specified when browsing a user's bookmarks.
Note that the defaults have different behavior, and requesting all bookmarks in
v2now also limits to 10 by default.Unlike the change to
user/resources, we add this tov2since the endpoint was not in use yet.How to Test
Covered by tests.
Checklist
Related Issues
Closes #599