Skip to content

[MNT] pre-commit updates#707

Merged
fkiraly merged 16 commits intoaiondemand:developfrom
satvshr:ruff
Mar 6, 2026
Merged

[MNT] pre-commit updates#707
fkiraly merged 16 commits intoaiondemand:developfrom
satvshr:ruff

Conversation

@satvshr
Copy link
Contributor

@satvshr satvshr commented Feb 25, 2026

fixes #704
Follows closely with 77 from aiondemand/aiondemand

Only real changes made were:

  • .flake8 deletion and replacement with ruff, they both lint (.flake8 being slower, it was also NOT a part of pre-commit), and all operations being provided by .flake8 were moved to ruff.
  • Removed pytest passing for all tests before pre-commit given it can slow pre-commit down by a lot and is also not the norm in other repos I have worked on (including openml-python).
  • Added .ruff-cache to .gitignore.
  • Updated pre-commit versions.
  • Changed CI to check for file changes.
  • Included tests for ruff checks.
  • Removed mypy.

Most changes are due to file endings being changed to LF

Copy link

@geetu040 geetu040 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me overall

One thing to keep in mind: since it runs only on changed files, even a small tweak in a file will require that file to pass all pre-commit checks. That's probably fine for new PRs, but it could mean some extra cleanup when touching older files. Hopefully it won't create too much overhead in practice.

@fkiraly please take a look and merge.

Copy link

@fkiraly fkiraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some conflicts to resolve, can you kindly have a look?

@satvshr
Copy link
Contributor Author

satvshr commented Mar 3, 2026

Solved, kindly merge sooner rather than later to avoid conflicts

@satvshr satvshr requested a review from fkiraly March 3, 2026 14:47
@fkiraly fkiraly merged commit e9840ed into aiondemand:develop Mar 6, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[MNT] pre-commit updates

3 participants