Merged
Conversation
geetu040
approved these changes
Mar 2, 2026
geetu040
left a comment
There was a problem hiding this comment.
Looks good to me overall
One thing to keep in mind: since it runs only on changed files, even a small tweak in a file will require that file to pass all pre-commit checks. That's probably fine for new PRs, but it could mean some extra cleanup when touching older files. Hopefully it won't create too much overhead in practice.
@fkiraly please take a look and merge.
fkiraly
requested changes
Mar 3, 2026
fkiraly
left a comment
There was a problem hiding this comment.
There are some conflicts to resolve, can you kindly have a look?
Contributor
Author
|
Solved, kindly merge sooner rather than later to avoid conflicts |
fkiraly
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #704
Follows closely with 77 from
aiondemand/aiondemandOnly real changes made were:
.flake8deletion and replacement withruff, they both lint (.flake8being slower, it was also NOT a part of pre-commit), and all operations being provided by.flake8were moved toruff.pytestpassing for all tests before pre-commit given it can slow pre-commit down by a lot and is also not the norm in other repos I have worked on (including openml-python)..ruff-cacheto.gitignore.testsforruffchecks.mypy.Most changes are due to file endings being changed to
LF