Fix: enforce Content-Type header via middleware with tests#735
Open
coderTanisha22 wants to merge 1 commit intoaiondemand:developfrom
Open
Fix: enforce Content-Type header via middleware with tests#735coderTanisha22 wants to merge 1 commit intoaiondemand:developfrom
coderTanisha22 wants to merge 1 commit intoaiondemand:developfrom
Conversation
Author
|
Hi @PGijsbers , I’ve implemented a fix for this issue. The solution introduces a global middleware that validates the 'Content-Type' header for POST, PUT, and PATCH requests with a request body, returning a 415 response when it is missing or invalid. I’ve also added isolated tests covering edge cases and ensuring compatibility with multipart and documentation endpoints. Would appreciate your review and any feedback. Thanks! |
Author
|
Reopened the PR after accidentally deleting and restoring the branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change(s)
Change Type: Fixed
Change Category: Internal
Changelog Entry:
Fix silent failure when 'Content-Type' header is missing for JSON requests.
Added a global middleware that validates the 'Content-Type' header for POST, PUT, and PATCH requests with a request body. If the header is missing or does not include 'application/json', the API now returns a '415 Unsupported Media Type' response instead of silently accepting the request.
The implementation ensures compatibility by:
How to Test
Automated tests have been added to cover these scenarios.
Checklist
Related Issues
Closes #622