Improve bounds-change handling for bottomToTop layout#135
Merged
bryankeller merged 1 commit intomasterfrom Apr 17, 2025
Merged
Conversation
brynbodayle
approved these changes
Apr 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
This PR improves some bounds-change handling for the
bottomToToplayout. The math is messy, but it works. There might be a deeper truth here that would simplify the calculation so that we don't need a different case for shrinking / growing bounds, and the weird clamp we need to do, but I haven't found it yet.Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-04-16.at.21.04.47.mp4
Motivation and Context
Fixes an issue where a bounds change caused the collection view to not preserve the bottom visible item properly.
How Has This Been Tested
Example app.
Types of changes
Checklist