Bk/fix preferred attributes content offset adjustment#149
Merged
bryankeller merged 3 commits intomasterfrom Nov 18, 2025
Merged
Bk/fix preferred attributes content offset adjustment#149bryankeller merged 3 commits intomasterfrom
bryankeller merged 3 commits intomasterfrom
Conversation
brynbodayle
previously approved these changes
Nov 18, 2025
bryankeller
deleted the
bk/fix-preferred-attributes-content-offset-adjustment
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
This fixes jumpy scrolling - the trick is to only consider fully-visible items when calculating the target content offset anchor, since partially-off-screen items could be resizing still.
Please review
@brynbodayle