Fix the contentOffsetAdjustment when overscrolling#154
Merged
bryankeller merged 2 commits intomasterfrom Feb 13, 2026
Merged
Conversation
brynbodayle
approved these changes
Feb 13, 2026
bryankeller
deleted the
bk/fix-overscroll-self-size-contentOffsetAdjustment
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
This fixes an issue that could cause jumpy scrolling when rubber-banding / over-scrolling at the top or bottom of the collection view. While over-scrolling, if an item self-sizes due to its visibility changing, we need to account for the over-scroll amount when calculating a
contentOffsetAdjustment. Before this change, we'd always calculate that offset without taking into account the over-scroll, causing the collection view to snap to its min / max content offset (even though you were beyond that).Review
@brynbodayle