Merged
Conversation
Fix comment Prefix
jparise
reviewed
Dec 15, 2025
| addAttribute("server.port", url.port) | ||
| addAttribute("url.scheme", url.scheme) | ||
|
|
||
| let urlRedaction = urlRedaction ?? defaultUrlRedaction |
There was a problem hiding this comment.
I wonder if this is the default behavior we want. It means that there isn't a way to skip redaction without passing in a non-redacting closure.
I'd lean toward not providing a default implementation and doing that in user code. We could provide a reference implementation as an example or as a public function that the caller could explicitly pass.
jparise
approved these changes
Dec 15, 2025
|
|
||
| // MARK: Internal | ||
|
|
||
| static let redacted = "REDACTED" |
There was a problem hiding this comment.
Could be useful for this to be public.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
x-amz-*parameters. Can be customized with closure.@bachand
@jparise