This repository was archived by the owner on May 20, 2021. It is now read-only.
Add detailed stage-level query progress info to frontend.#168
Open
qwwqwwq wants to merge 15 commits intoairbnb:masterfrom
Open
Add detailed stage-level query progress info to frontend.#168qwwqwwq wants to merge 15 commits intoairbnb:masterfrom
qwwqwwq wants to merge 15 commits intoairbnb:masterfrom
Conversation
added 15 commits
March 6, 2016 21:14
Signed-off-by: qwwqwwq <jeffreyquinn@Jeffreys-MacBook-Air.local>
Signed-off-by: qwwqwwq <jeffreyquinn@Jeffreys-MacBook-Air.local>
Signed-off-by: qwwqwwq <jeffreyquinn@Jeffreys-MacBook-Air.local>
Signed-off-by: qwwqwwq <jeffreyquinn@Jeffreys-MacBook-Air.local>
Signed-off-by: qwwqwwq <jeffreyquinn@Jeffreys-MacBook-Air.local>
Signed-off-by: qwwqwwq <jeffreyquinn@Jeffreys-MacBook-Air.local>
Signed-off-by: qwwqwwq <jeffreyquinn@Jeffreys-MacBook-Air.local>
Signed-off-by: qwwqwwq <jeffreyquinn@Jeffreys-MacBook-Air.local>
Signed-off-by: qwwqwwq <jeffreyquinn@Jeffreys-MacBook-Air.local>
Signed-off-by: qwwqwwq <jeffreyquinn@Jeffreys-MacBook-Air.local>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR wires through the detailed prestodb stage-level query progress info into the frontend. This is the same info that is shown typographically when you use
presto-clito run a query, i.e.:Now, clicking on the progress bar of a running query from the
RunsTablewill bring up a modal that looks like this:I wasn't really sure where this could fit in the page so I figured a modal was the safest bet for now.
I didn't see any javascript tests in the project currently, but if the maintainers have opinions about which testing frameworks to use I'd be happy to add tests for this feature.
This also required some backend changes but those were more minimal, they basically amount to adding a new field to the Job object.