Open
Conversation
rgruener
commented
Nov 17, 2025
| def flatSchema: StructType = if (withTime) StructType(baseFlatSchema :+ timeField) else baseFlatSchema | ||
| def flatZSchema: api.StructType = flatSchema.toChrononSchema("Flat") | ||
| lazy val keyToBytes: Any => Array[Byte] = AvroConversions.encodeBytes(keyZSchema, GenericRowHandler.func) | ||
| // For global aggregations, use plain UTF-8 bytes for a dummy key (no need for an avro schema) |
Contributor
Author
There was a problem hiding this comment.
I honestly think this is a bit of a hack but it is necessary since most KVStore implementations will require a non-empty key.
Global aggregations also pretty much require the user to cache the stored results since they will be fetched with every online request. It would be helpful to be more opinionated on how they are stored but I don't want to broadly affect the code base
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This adds support for
keys=Noneto signify a global aggregation. Global aggregations can be added to a join and are then joined with each record on the left since they have no keys.Why / Goal
Global aggregations are extremely useful for computing sane defaults to be used later in a join coalesce.
Test Plan
Checklist
Reviewers