[Logging]Disable logging unless users explicitly set the samplePercent #1083
Open
[Logging]Disable logging unless users explicitly set the samplePercent #1083
Conversation
pengyu-hou
approved these changes
Jan 15, 2026
Collaborator
pengyu-hou
left a comment
There was a problem hiding this comment.
Thanks for the quick change.
Shiyinghaha
approved these changes
Jan 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Previously, all Joins had logging enabled by default at 100% sample rate. From statistics for Airbnb users, nearly 96% of the new joins has sample percent 100%. This caused unnecessary logging overhead for users who didn't need it.
Disable request logging by default for Joins unless users explicitly set sample_percent.
Changes
Usage
Before: logging enabled by default
Join(left=..., right_parts=...)
After: logging disabled by default, must explicitly enable
Join(left=..., right_parts=..., sample_percent=100.0)
Why / Goal
Test Plan
Checklist
Reviewers
@pengyu-hou @hzding621 @Shiyinghaha