Skip to content

[Logging]Disable logging unless users explicitly set the samplePercent #1083

Open
yuli-han wants to merge 6 commits intomainfrom
ylh--disable-logging-unless-user-set-it
Open

[Logging]Disable logging unless users explicitly set the samplePercent #1083
yuli-han wants to merge 6 commits intomainfrom
ylh--disable-logging-unless-user-set-it

Conversation

@yuli-han
Copy link
Collaborator

@yuli-han yuli-han commented Jan 15, 2026

Summary

Previously, all Joins had logging enabled by default at 100% sample rate. From statistics for Airbnb users, nearly 96% of the new joins has sample percent 100%. This caused unnecessary logging overhead for users who didn't need it.

Disable request logging by default for Joins unless users explicitly set sample_percent.

Changes

  • Changed sample_percent default from 100.0 to None in the Python Join API
  • Updated test fixtures to explicitly set sample_percent=100.0 where logging is expected
  • Updated docstring to document the new default behavior

Usage

Before: logging enabled by default
Join(left=..., right_parts=...)

After: logging disabled by default, must explicitly enable
Join(left=..., right_parts=..., sample_percent=100.0)

Why / Goal

Test Plan

  • Added Unit Tests
  • Covered by existing CI
  • Integration tested

Checklist

  • Documentation update

Reviewers

@pengyu-hou @hzding621 @Shiyinghaha

Copy link
Collaborator

@pengyu-hou pengyu-hou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants