Add support to register UDFs in Flink#926
Open
piyush-zlai wants to merge 1 commit intoairbnb:mainfrom
Open
Conversation
hzding621
approved these changes
Mar 7, 2025
caiocamatta-stripe
approved these changes
May 28, 2025
Collaborator
caiocamatta-stripe
left a comment
caiocamatta-stripe
left a comment
There was a problem hiding this comment.
@piyush-zlai looks good. Is it worth adding a test case toSparkExpressionEvalFnTest or an integration test in FlinkJobIntegrationTest.scala?
Collaborator
Author
|
@caiocamatta-stripe - thanks for the r. Could move the current tests over to the Flink test side. Might help me get around the flakes I've been seeing in the current test case setup as I've added some which might be conflicting with the other spark tests.. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add support for Flink UDF registration. This is currently marked as a todo in our Flink streaming integration - this PR brings the support to par with how we support & register udfs in Spark structured streaming.
Why / Goal
Bring Flink UDF support to parity with Spark.
Test Plan
Checklist
Reviewers