Exclude backfill start date for versioning in join jobs#960
Open
pengyu-hou wants to merge 1 commit intomainfrom
Open
Exclude backfill start date for versioning in join jobs#960pengyu-hou wants to merge 1 commit intomainfrom
pengyu-hou wants to merge 1 commit intomainfrom
Conversation
hzding621
requested changes
Apr 5, 2025
Collaborator
There was a problem hiding this comment.
For this change we must introduce a new entry in semantic_hash_options because this is not backward compatible and will cause all joins that use GroupBys with backfill_start_date to have a new semantic hash and trigger an unexpected archive. You also need to handle the semantic hash migration, similar to #801
Collaborator
Author
Oh yes, thanks for the pointer. I was about to ask the PR reference. Will address it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR will add a flag to exclude backfill start date in the join part in versioning check.
Why / Goal
Exclude the backfill start date in the join part, it is intended to trigger separate group by backfill jobs, and semantic hash is only used in join for versioning check, therefore, exclude it for more flexibility of group by backfill jobs
Test Plan
Checklist
Reviewers
@airbnb/airbnb-chronon-maintainers