Merged
Conversation
Size Changes
View raw build statsPrevious (master){
"visx-annotation": {
"esm": 28559,
"lib": 37653
},
"visx-axis": {
"esm": 20679,
"lib": 25089
},
"visx-bounds": {
"esm": 2662,
"lib": 3136
},
"visx-brush": {
"esm": 52910,
"lib": 55762
},
"visx-chord": {
"esm": 2657,
"lib": 3367
},
"visx-clip-path": {
"esm": 3376,
"lib": 4397
},
"visx-curve": {
"esm": 323,
"lib": 1462
},
"visx-delaunay": {
"esm": 2299,
"lib": 3029
},
"visx-demo": {
"esm": 0,
"lib": 0
},
"visx-drag": {
"esm": 12368,
"lib": 13865
},
"visx-event": {
"esm": 3815,
"lib": 5091
},
"visx-geo": {
"esm": 12438,
"lib": 15396
},
"visx-glyph": {
"esm": 12117,
"lib": 15641
},
"visx-gradient": {
"esm": 15424,
"lib": 19410
},
"visx-grid": {
"esm": 16648,
"lib": 19823
},
"visx-group": {
"esm": 1245,
"lib": 1675
},
"visx-heatmap": {
"esm": 6387,
"lib": 7266
},
"visx-hierarchy": {
"esm": 10161,
"lib": 14656
},
"visx-legend": {
"esm": 23878,
"lib": 29277
},
"visx-marker": {
"esm": 7804,
"lib": 9643
},
"visx-mock-data": {
"esm": 326036,
"lib": 329336
},
"visx-network": {
"esm": 4118,
"lib": 5907
},
"visx-pattern": {
"esm": 9161,
"lib": 11621
},
"visx-point": {
"esm": 1003,
"lib": 1781
},
"visx-react-spring": {
"esm": 13095,
"lib": 16276
},
"visx-responsive": {
"esm": 15441,
"lib": 17433
},
"visx-sankey": {
"esm": 3278,
"lib": 4160
},
"visx-scale": {
"esm": 19205,
"lib": 30251
},
"visx-shape": {
"esm": 81601,
"lib": 102299
},
"visx-stats": {
"esm": 12862,
"lib": 13971
},
"visx-text": {
"esm": 8297,
"lib": 9794
},
"visx-threshold": {
"esm": 2386,
"lib": 2946
},
"visx-tooltip": {
"esm": 13910,
"lib": 18915
},
"visx-vendor": {
"esm": 2492,
"lib": 2702
},
"visx-visx": {
"esm": 1524,
"lib": 4155
},
"visx-voronoi": {
"esm": 2007,
"lib": 2615
},
"visx-wordcloud": {
"esm": 2417,
"lib": 3186
},
"visx-xychart": {
"esm": 171410,
"lib": 220698
},
"visx-zoom": {
"esm": 15880,
"lib": 18321
}
}Current{
"visx-annotation": {
"esm": 28559,
"lib": 36491
},
"visx-axis": {
"esm": 20709,
"lib": 25119
},
"visx-bounds": {
"esm": 2662,
"lib": 3136
},
"visx-brush": {
"esm": 52910,
"lib": 55596
},
"visx-chord": {
"esm": 2663,
"lib": 3373
},
"visx-clip-path": {
"esm": 3394,
"lib": 4415
},
"visx-curve": {
"esm": 323,
"lib": 1462
},
"visx-delaunay": {
"esm": 2305,
"lib": 3035
},
"visx-demo": {
"esm": 0,
"lib": 0
},
"visx-drag": {
"esm": 12368,
"lib": 13865
},
"visx-event": {
"esm": 3815,
"lib": 5091
},
"visx-geo": {
"esm": 12450,
"lib": 15408
},
"visx-glyph": {
"esm": 12165,
"lib": 15689
},
"visx-gradient": {
"esm": 15496,
"lib": 19482
},
"visx-grid": {
"esm": 16678,
"lib": 19853
},
"visx-group": {
"esm": 1251,
"lib": 1681
},
"visx-heatmap": {
"esm": 6399,
"lib": 7278
},
"visx-hierarchy": {
"esm": 10161,
"lib": 14656
},
"visx-legend": {
"esm": 23920,
"lib": 29153
},
"visx-marker": {
"esm": 7834,
"lib": 9673
},
"visx-mock-data": {
"esm": 326036,
"lib": 329336
},
"visx-network": {
"esm": 4124,
"lib": 5913
},
"visx-pattern": {
"esm": 9161,
"lib": 11621
},
"visx-point": {
"esm": 1003,
"lib": 1781
},
"visx-react-spring": {
"esm": 13119,
"lib": 16134
},
"visx-responsive": {
"esm": 15447,
"lib": 17439
},
"visx-sankey": {
"esm": 3278,
"lib": 4160
},
"visx-scale": {
"esm": 19205,
"lib": 30085
},
"visx-shape": {
"esm": 81775,
"lib": 102141
},
"visx-stats": {
"esm": 12868,
"lib": 13977
},
"visx-text": {
"esm": 8309,
"lib": 9806
},
"visx-threshold": {
"esm": 2386,
"lib": 2946
},
"visx-tooltip": {
"esm": 13934,
"lib": 18441
},
"visx-vendor": {
"esm": 2492,
"lib": 2702
},
"visx-visx": {
"esm": 1524,
"lib": 3989
},
"visx-voronoi": {
"esm": 2013,
"lib": 2621
},
"visx-wordcloud": {
"esm": 2423,
"lib": 3192
},
"visx-xychart": {
"esm": 171572,
"lib": 216544
},
"visx-zoom": {
"esm": 16001,
"lib": 18276
}
} |
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the visx monorepo from Yarn 1 to Yarn 4, updating internal dependency resolution from specific version numbers to workspace protocol references.
- Upgrades package manager from Yarn 1.22.19 to Yarn 4.10.3
- Replaces hardcoded version numbers with
workspace:*for internal @visx packages - Updates TypeScript syntax for indexed access types to use proper parentheses
- Configures Yarn 4 with node-modules linker and hoisting limits
Reviewed Changes
Copilot reviewed 36 out of 38 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| package.json | Updates Yarn version requirement, removes husky, updates packageManager field, removes nohoist config |
| .yarnrc.yml | Adds Yarn 4 configuration with node-modules linker |
| .gitignore | Adds Yarn 4-specific files to ignore list |
| .github/workflows/*.yml | Updates CI workflows for Yarn 4 compatibility |
| packages/*/package.json | Replaces specific version numbers with workspace:* for internal dependencies |
| packages/visx-vendor/package.json | Adds installConfig.hoistingLimits for vendor package |
| packages/visx-vendor/Readme.md | Updates documentation to reflect hoistingLimits instead of nohoist |
| packages/visx-xychart/src/components/Tooltip.tsx | Adds ts-expect-error comment and reformats boxShadow string |
| packages/visx-xychart/src/components/series/private/BaseAreaStack.tsx | Fixes TypeScript indexed access type syntax |
| packages/visx-scale/src/operators/scaleOperator.ts | Fixes TypeScript indexed access type syntax |
| packages/visx-sankey/test/Sankey.test.tsx | Fixes TypeScript indexed access type syntax |
Comments suppressed due to low confidence (1)
packages/visx-xychart/src/components/Tooltip.tsx:231
- The nullish coalescing chain includes an unreachable
null ??expression at line 228. This creates dead code sincenull ?? theme?.gridStyles?.strokewill always resolve totheme?.gridStyles?.stroke. Consider removing this line or documenting its purpose if it serves as a placeholder.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
🎉 This PR is included in version |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💥 Breaking Changes
nohoist=>installConfig.hoistingLimits: "workspaces"🏠 Internal