Try to add message template placeholders to more messages.#145
Merged
airbreather merged 5 commits intomainfrom Feb 13, 2026
Merged
Try to add message template placeholders to more messages.#145airbreather merged 5 commits intomainfrom
airbreather merged 5 commits intomainfrom
Conversation
The first one, "a random player", is the trickiest: there's no obvious way to get the list of connected players, and archipelago.js doesn't add that on in any realistically usable way, so the ideal way to do this is impossible, and the closest possible alternative is, I think, prohibitively hard. But I think the closest that I can reasonably get to that alternative is actually ideal after all. Most likely, the use case for adding a placeholder for a random player is to cheer on someone else who hasn't yet hit their goal anyway. If so, then it's not a problem that I can't distinguish online from offline among players who have. Completely 100% untested so far, but I need to walk away for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first one, "a random player", is the trickiest: there's no obvious way to get the list of connected players, and archipelago.js doesn't add that on in any realistically usable way, so the ideal way to do this is impossible, and the closest possible alternative is, I think, prohibitively hard.
But I think the closest that I can reasonably get to that alternative is actually ideal after all. Most likely, the use case for adding a placeholder for a random player is to cheer on someone else who hasn't yet hit their goal anyway. If so, then it's not a problem that I can't distinguish online from offline among players who have.