fix: Normalize API URLs to handle trailing slashes in Config API resolution#922
Merged
Aaron ("AJ") Steers (aaronsteers) merged 1 commit intomainfrom Dec 18, 2025
Conversation
…lution - Strip trailing slashes when comparing api_root to CLOUD_API_ROOT in get_config_api_root() - Handle NotImplementedError in CloudWorkspace.get_organization() when raise_on_error=False This fixes issues where MCP tools like list_cloud_workspaces and check_airbyte_cloud_workspace would fail with 'Missing AIRBYTE_CLOUD_CONFIG_API_URL' when the API URL had a trailing slash. Co-Authored-By: aldo.gonzalez@airbyte.io <aldo.gonzalez@airbyte.io>
Contributor
Author
Original prompt from aldo.gonzalez@airbyte.io |
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
👋 Greetings, Airbyte Team Member!Here are some helpful tips and reminders for your convenience. Testing This PyAirbyte VersionYou can test this version of PyAirbyte using the following: # Run PyAirbyte CLI from this branch:
uvx --from 'git+https://github.com/airbytehq/PyAirbyte.git@devin/1766094723-fix-config-api-url-normalization' pyairbyte --help
# Install PyAirbyte from this branch for development:
pip install 'git+https://github.com/airbytehq/PyAirbyte.git@devin/1766094723-fix-config-api-url-normalization'Helpful ResourcesPR Slash CommandsAirbyte Maintainers can execute the following slash commands on your PR:
Community SupportQuestions? Join the #pyairbyte channel in our Slack workspace. |
Aaron ("AJ") Steers (aaronsteers)
approved these changes
Dec 18, 2025
Contributor
Aaron ("AJ") Steers (aaronsteers)
left a comment
There was a problem hiding this comment.
Looks good! ✅
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an issue where MCP tools (
list_cloud_workspaces,check_airbyte_cloud_workspace) would fail with "Missing AIRBYTE_CLOUD_CONFIG_API_URL" when the API URL contained a trailing slash or other minor variants.Root cause:
get_config_api_root()used exact string comparison (api_root == CLOUD_API_ROOT) which failed for URLs likehttps://api.airbyte.com/v1/(with trailing slash).Changes:
NotImplementedErroringet_organization(raise_on_error=False)so the method degrades gracefully instead of crashingReview & Testing Checklist for Human
NotImplementedErroringet_organization()won't mask unrelated programming errorsRecommended test plan:
check_airbyte_cloud_workspaceandlist_cloud_workspacestoolsNotes
Important
Auto-merge enabled.
This PR is set to merge automatically when all requirements are met.
Note
Auto-merge may have been disabled. Please check the PR status to confirm.