Skip to content

fix: Normalize API URLs to handle trailing slashes in Config API resolution #922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Aaron ("AJ") Steers (aaronsteers) merged 1 commit into from
Dec 18, 2025
Merged

fix: Normalize API URLs to handle trailing slashes in Config API resolution #922

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion airbyte/_util/api_util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,8 @@ def get_config_api_root(api_root: str) -> str:
return str(config_api_override)

# Fall back to deriving from the main API root
if api_root == CLOUD_API_ROOT:
# Normalize URLs by stripping trailing slashes to handle common variants
if api_root.rstrip("/") == CLOUD_API_ROOT.rstrip("/"):
return CLOUD_CONFIG_API_ROOT

raise NotImplementedError(
Expand Down
2 changes: 1 addition & 1 deletion airbyte/cloud/workspaces.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,7 +267,7 @@ def get_organization(
"""
try:
info = self._organization_info
except AirbyteError:
except (AirbyteError, NotImplementedError):
if raise_on_error:
raise
return None
Expand Down