fix: Add required permissions for prerelease workflow#911
Conversation
Co-Authored-By: AJ Steers <aj@airbyte.io>
Original prompt from AJ Steers |
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
👋 Greetings, Airbyte Team Member!Here are some helpful tips and reminders for your convenience. Testing This PyAirbyte VersionYou can test this version of PyAirbyte using the following: # Run PyAirbyte CLI from this branch:
uvx --from 'git+https://github.com/airbytehq/PyAirbyte.git@devin/1765670835-fix-prerelease-permissions' pyairbyte --help
# Install PyAirbyte from this branch for development:
pip install 'git+https://github.com/airbytehq/PyAirbyte.git@devin/1765670835-fix-prerelease-permissions'Helpful ResourcesPR Slash CommandsAirbyte Maintainers can execute the following slash commands on your PR:
Community SupportQuestions? Join the #pyairbyte channel in our Slack workspace. |
|
Caution Review failedThe pull request is closed. 📝 WalkthroughWalkthroughUpdated GitHub Actions workflow permissions in the prerelease-command workflow by replacing Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Fixes the
/prereleaseslash command workflow which was failing with:The fix adds the required permissions to
prerelease-command.ymlso it can call the nestedpypi_publish.ymlworkflow:contents: write- Required by the publish job for GitHub release uploads (only used on tag pushes)id-token: write- Required for OIDC trusted publishing to PyPIReview & Testing Checklist for Human
/prereleasecommand end-to-end by commenting/prereleaseon a test PR after merging. This is the only way to verify the fix works since the workflow requires the slash command dispatch infrastructure.publish.ymlinstead ofpypi_publish.yml), publishing will fail with an explicit error. Check the workflow logs if it fails.Notes
contents: writepermission is broader than strictly needed for prereleases (which don't upload to GitHub releases), but is required because the nestedpublishjob declares it at the job level.Link to Devin run: https://app.devin.ai/sessions/c86d36be59664129af00617d0e66bc4d
Requested by: AJ Steers (Aaron ("AJ") Steers (@aaronsteers))
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.