Skip to content

Commit 5823dfc

Browse files
refactor: rename message_file to stdout_file in from_completed_process
- Rename parameter from message_file to stdout_file for better clarity - Update caller in run_docker_command() to use new parameter name - Addresses GitHub PR feedback from @aaronsteers Co-Authored-By: AJ Steers <[email protected]>
1 parent b20b169 commit 5823dfc

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

airbyte_cdk/test/entrypoint_wrapper.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -298,10 +298,10 @@ def from_completed_process(
298298
cls,
299299
completed_process: subprocess.CompletedProcess[str],
300300
*,
301-
message_file: Path | None = None,
301+
stdout_file: Path | None = None,
302302
) -> "EntrypointOutput":
303-
"""Create EntrypointOutput from a completed subprocess with optional message file."""
304-
instance = cls(message_file=message_file)
303+
"""Create EntrypointOutput from a completed subprocess with optional stdout file."""
304+
instance = cls(message_file=stdout_file)
305305
instance._completed_process = completed_process
306306
return instance
307307

airbyte_cdk/utils/docker.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -438,7 +438,7 @@ def run_docker_command(
438438

439439
return EntrypointOutput.from_completed_process(
440440
completed_process,
441-
message_file=stdout_path,
441+
stdout_file=stdout_path,
442442
)
443443

444444

0 commit comments

Comments
 (0)