clean up IConnector interface

Author: aaronsteers

airbyte_cdk/test/declarative/utils/job_runner.py

@@ -1,3 +1,7 @@
+# Copyright (c) 2025 Airbyte, Inc., all rights reserved.
+"""Job runner for Airbyte Standard Tests."""
+
+import logging
 import tempfile
 import uuid
 from dataclasses import asdict
@@ -19,11 +23,15 @@
 
 @runtime_checkable
 class IConnector(Protocol):
-    """A connector that can be run in a test scenario."""
+    """A connector that can be run in a test scenario.
+
+    Note: We currently use 'spec' to determine if we have a connector object.
+    In the future, it would be preferred to leverage a 'launch' method instead,
+    directly on the connector (which doesn't yet exist).
+    """
 
-    def launch(self, args: list[str] | None) -> None:
-        """Launch the connector with the given arguments."""
-        ...
+    def spec(self, logger: logging.Logger) -> Any:
+        """Connectors should have a `spec` method."""
 
 
 def run_test_job(
@@ -45,13 +53,7 @@ def run_test_job(
     if isinstance(connector, type) or callable(connector):
         # If the connector is a class or a factory lambda, instantiate it.
         connector_obj = connector()
-    elif (
-        isinstance(
-            connector,
-            IConnector,
-        )
-        or True
-    ):  # TODO: Get a valid protocol check here
+    elif isinstance(connector, IConnector):  # TODO: Get a valid protocol check here
         connector_obj = connector
     else:
         raise ValueError(

unit_tests/test/test_standard_tests.py

@@ -0,0 +1,32 @@
+# Copyright (c) 2024 Airbyte, Inc., all rights reserved.
+"""Unit tests for FAST Airbyte Standard Tests."""
+
+from typing import Any
+
+import pytest
+
+from airbyte_cdk.sources.concurrent_source.concurrent_source import ConcurrentSource
+from airbyte_cdk.sources.declarative.declarative_source import DeclarativeSource
+from airbyte_cdk.sources.source import Source
+from airbyte_cdk.test.declarative.utils.job_runner import IConnector
+
+
+@pytest.mark.parametrize(
+    "input, expected",
+    [
+        (DeclarativeSource, True),
+        (Source, True),
+        (None, False),
+        ("", False),
+        ([], False),
+        ({}, False),
+        (object(), False),
+    ],
+)
+def test_is_iconnector_check(input: Any, expected: bool) -> None:
+    """Assert whether inputs are valid as an IConnector object or class."""
+    if isinstance(input, type):
+        assert issubclass(input, IConnector) == expected
+        return
+
+    assert isinstance(input, IConnector) == expected