fix(property chunking): fix delimiter count since commas are encoded as three characters

[brianjlai]

Commas are encoded as %2C so we need to increment the count by 3 instead of 1.

Summary by CodeRabbit

• Bug Fixes
  • Improved accuracy of property chunking when character limits are applied, ensuring correct handling of delimiters between properties.
• Tests
  • Updated test cases to reflect changes in character limit calculations for property chunking, ensuring tests align with the revised logic.

[coderabbitai]

📝 Walkthrough

Walkthrough

The changes update the logic for calculating property chunk sizes in the PropertyChunking class, specifically adjusting the delimiter size from 1 to 3 characters when the property limit type is set to "characters". Corresponding unit tests are updated to reflect new character limits and expected chunking behavior, ensuring consistency with the revised delimiter calculation.

Changes

File(s)	Change Summary
airbyte_cdk/sources/declarative/requesters/query_properties/property_chunking.py	Increased delimiter size from 1 to 3 characters in property chunk size calculation for character-based limits.
unit_tests/sources/declarative/requesters/query_properties/test_property_chunking.py	Updated character limits and expected results in two test cases to align with the new delimiter calculation.

Suggested labels

bug

Suggested reviewers

• darynaishchenko
• maxi297

Would you like to add a note in the code comments explaining why the delimiter size was increased to 3 characters, to help future maintainers understand the context? Wdyt?

Tip

⚡💬 Agentic Chat (Pro Plan, General Availability)

• We're introducing multi-step agentic chat in review comments and issue comments, within and outside of PR's. This feature enhances review and issue discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments and add commits to existing pull requests.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between db979fa and a9bfe30.

📒 Files selected for processing (2)

• airbyte_cdk/sources/declarative/requesters/query_properties/property_chunking.py (1 hunks)
• unit_tests/sources/declarative/requesters/query_properties/test_property_chunking.py (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (2)

• airbyte_cdk/sources/declarative/requesters/query_properties/property_chunking.py
• unit_tests/sources/declarative/requesters/query_properties/test_property_chunking.py

⏰ Context from checks skipped due to timeout of 90000ms (9)

• GitHub Check: Check: 'source-pokeapi' (skip=false)
• GitHub Check: Check: 'source-amplitude' (skip=false)
• GitHub Check: Check: 'source-shopify' (skip=false)
• GitHub Check: Check: 'source-hardcoded-records' (skip=false)
• GitHub Check: Pytest (All, Python 3.11, Ubuntu)
• GitHub Check: Pytest (Fast)
• GitHub Check: Pytest (All, Python 3.10, Ubuntu)
• GitHub Check: SDM Docker Image Build
• GitHub Check: Analyze (python)

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

🧹 Nitpick comments (1)

unit_tests/sources/declarative/requesters/query_properties/test_property_chunking.py (1)

54-56: Comment clarification could be improved?

The comment explains laurie%2jaclyn%2 == 14, which seems to imply the delimiter is encoded as %2. However, the PR description mentions commas are encoded as %2C (3 characters).

Would it be clearer if this calculation showed the full delimiter encoding? Something like: laurie (6) + %2 (2) + jaclyn (6) = 14? This would make it more explicit for future readers, wdyt?

-            14,  # laurie%2jaclyn%2 == 14
+            14,  # laurie (6) + %2 (2) + jaclyn (6) = 14

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 58a89d6 and db979fa.

📒 Files selected for processing (2)

• airbyte_cdk/sources/declarative/requesters/query_properties/property_chunking.py (1 hunks)
• unit_tests/sources/declarative/requesters/query_properties/test_property_chunking.py (1 hunks)

🧰 Additional context used

🧬 Code Graph Analysis (1)

unit_tests/sources/declarative/requesters/query_properties/test_property_chunking.py (2)

airbyte_cdk/sources/declarative/requesters/query_properties/property_chunking.py (1)

• PropertyLimitType (14-21)

airbyte_cdk/sources/declarative/models/declarative_component_schema.py (1)

• PropertyLimitType (1229-1231)

⏰ Context from checks skipped due to timeout of 90000ms (9)

• GitHub Check: Check: 'source-pokeapi' (skip=false)
• GitHub Check: Check: 'source-amplitude' (skip=false)
• GitHub Check: Check: 'source-shopify' (skip=false)
• GitHub Check: Check: 'source-hardcoded-records' (skip=false)
• GitHub Check: Pytest (All, Python 3.11, Ubuntu)
• GitHub Check: Pytest (All, Python 3.10, Ubuntu)
• GitHub Check: SDM Docker Image Build
• GitHub Check: Analyze (python)
• GitHub Check: Pytest (Fast)

🔇 Additional comments (1)

unit_tests/sources/declarative/requesters/query_properties/test_property_chunking.py (1)

46-47: Limit update matches the code change

The limit increase from 15 to 18 correctly reflects the change in delimiter character count from 1 to 2. This ensures the test expectations remain consistent with the implementation.