Skip to content

fix(property chunking): fix delimiter count since commas are encoded as three characters #495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brianjlai merged 2 commits into from
Apr 18, 2025
Merged

fix(property chunking): fix delimiter count since commas are encoded as three characters #495

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
db979fa
fix delimiter count since commas are encoded as two characters
brianjlai Apr 18, 2025
a9bfe30
comma delimiter encoding is 3 character %2C
brianjlai Apr 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion airbyte_cdk/sources/declarative/requesters/query_properties/property_chunking.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ def get_request_property_chunks(
# todo: Add ability to specify parameter delimiter representation and take into account in property_field_size
property_field_size = (
len(property_field)
+ 1 # The +1 represents the extra character for the delimiter in between properties
+ 3 # The +3 represents the extra characters for encoding the delimiter in between properties
if self.property_limit_type == PropertyLimitType.characters
else 1
)
Expand Down
4 changes: 2 additions & 2 deletions unit_tests/sources/declarative/requesters/query_properties/test_property_chunking.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,15 +43,15 @@
["kate", "laurie", "jaclyn"],
None,
PropertyLimitType.characters,
15,
20,
[["kate", "laurie"], ["jaclyn"]],
id="test_property_chunking_limit_characters",
),
pytest.param(
["laurie", "jaclyn", "kaitlin"],
None,
PropertyLimitType.characters,
12,
17, # laurie%2Cjaclyn%2C == 18, so this will create separate chunks
[["laurie"], ["jaclyn"], ["kaitlin"]],
id="test_property_chunking_includes_extra_delimiter",
),
Expand Down
Loading