-
Notifications
You must be signed in to change notification settings - Fork 32
fix(file-api): fix schema field for file name #502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 WalkthroughWalkthroughThe changes update the attribute name in the Changes
Suggested labels
By the way, would you like to double-check for any typos like 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (10)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
airbyte_cdk/sources/file_based/file_record_data.py(1 hunks)unit_tests/sources/file_based/stream/test_default_file_based_stream.py(2 hunks)
🧰 Additional context used
🪛 GitHub Actions: Pytest (Fast)
unit_tests/sources/file_based/stream/test_default_file_based_stream.py
[error] 284-286: pydantic.v1.error_wrappers.ValidationError: 1 validation error for FileRecordData - field 'file_name' required but missing
🪛 GitHub Actions: PyTest Matrix
unit_tests/sources/file_based/stream/test_default_file_based_stream.py
[error] 284-286: pydantic.v1.error_wrappers.ValidationError: 1 validation error for FileRecordData - field 'file_name' required but missing.
⏰ Context from checks skipped due to timeout of 90000ms (7)
- GitHub Check: Check: 'source-pokeapi' (skip=false)
- GitHub Check: Check: 'source-amplitude' (skip=false)
- GitHub Check: Check: 'source-google-drive' (skip=false)
- GitHub Check: Check: 'source-shopify' (skip=false)
- GitHub Check: Check: 'source-hardcoded-records' (skip=false)
- GitHub Check: SDM Docker Image Build
- GitHub Check: Analyze (python)
🔇 Additional comments (2)
airbyte_cdk/sources/file_based/file_record_data.py (1)
17-17: Renaming field fromfilenametofile_namealigns with schema definition.The change from
filenametofile_namefixes the schema field alignment issue mentioned in the PR objectives. This ensures consistency between the code and schema definition, which is a good improvement.unit_tests/sources/file_based/stream/test_default_file_based_stream.py (1)
340-340: Updating dictionary key to match the renamed field.The update to change
"filename"to"file_name"in the expected output is correct and consistent with the field rename in theFileRecordDataclass.
Fix the file name field to the one in the schema:
Summary by CodeRabbit
Refactor
Tests